Bug causing default commands to override custom commands

Summary:

  • If a custom command shares its name with a default command or alias,
  • And the default command or command to which the alias points is enabled,
  • And the custom command is on cooldown,
  • And the custom command is used,
  • Then the default command or command to which the alias points is called

Steps to reproduce:

  • Enable the default command !songs
  • Create a custom command named !sr
    • !addcom !sr Test
  • Type !sr into your chat
  • Before 5 seconds elapse, type !sr again

Expected results:

  • Nightbot sends the message Test once (because the custom command !sr is on cooldown the second time it is called)

Actual results:

  • Nightbot sends the messages:
    • Test
    • @username -> You must specify a song to search for.

Extra information:

  • This bug also occurs when a custom command that does not share its name with a default command or alias is an alias to a custom command that shares its name with a default command or alias.
    For example:
    • !songs1 and !songs2 are both aliases to a custom command named !songs
    • If !songs1 and !songs2 are called successively, then Nightbot will reply twice, first with the output of the custom command !songs and second with the output of the default command !songs

The return value of commands in cooldown was incorrect. This should be fixed now.

1 Like

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.